fix: honor disable_trace_padding in cairo_run_fuzzed_program
#2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The hardcoded Did you hit a concrete issue with the current behavior, or is this purely a consistency fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
Previously cairo_run_fuzzed_program always passed false into CairoRunner::end_run, so the disable_trace_padding flag in CairoRunConfig only affected builtin segment padding but could not prevent padding the number of steps to a power of two in proof mode. This made its behaviour inconsistent with cairo_run and cairo_run_pie and effectively ignored part of the public configuration in fuzzed runs.
Summary:
Pass cairo_run_config.disable_trace_padding into cairo_runner.end_run in cairo_run_fuzzed_program so that fuzzed runs respect the same trace padding semantics as the main run helpers.